Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kibana metricset] Conditionally skip integration tests #7732

Closed
ycombinator opened this issue Jul 25, 2018 · 0 comments
Closed

[Kibana metricset] Conditionally skip integration tests #7732

ycombinator opened this issue Jul 25, 2018 · 0 comments
Assignees
@ycombinator
Labels
Metricbeat Metricbeat

Comments

@ycombinator
Copy link
Contributor

Implement this FIXME:

beats/metricbeat/module/kibana/stats/stats_integration_test.go

Lines 31 to 47 in 3d22932

t.Skip("Skipping until we find a way to conditionally skip this for Kibana < 6.4.0") // FIXME
compose.EnsureUp(t, "kibana")
f := mbtest.NewReportingMetricSetV2(t, mtest.GetConfig("stats"))
// FIXME! See skip above
// version, err := kibana.GetVersion(f.http, "api/stats")
// if err != nil {
// t.Fatal("getting kibana version", err)
// }
// isStatsAPIAvailable, err := kibana.IsStatsAPIAvailable(version)
// if err != nil {
// t.Fatal("checking if kibana stats API is available", err)
// }
// t.Skip("Kibana stats API is not available until 6.4.0")

@ycombinator ycombinator added the Metricbeat Metricbeat label Jul 25, 2018
@ycombinator ycombinator self-assigned this Jul 25, 2018
@ycombinator ycombinator changed the title [Kibana metricst] Conditionally skip integration tests [Kibana metricset] Conditionally skip integration tests Jul 25, 2018
This was referenced Jul 25, 2018
Merged
Merged
@ycombinator ycombinator mentioned this issue Sep 18, 2018
Merged
ycombinator added a commit that referenced this issue Sep 18, 2018
@ycombinator
Cherry-pick #7749 to 6.x: [Kibana metricset] Make integration test co…
95d661f 
…nditional on Kibana version (#8338)

Cherry-pick of PR #7749 to 6.x branch. Original message: 

Resolves #7732.

This PR removes the `FIXME` from the Kibana metricset's integration test. It skips the test if the version of Kibana used for the test doesn't implement the API the test will need to exercise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ycombinator ycombinator

Labels
Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ycombinator