Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat diskio metricset doesn't work on Windows XP/2003 #2885

Closed
andrewkroh opened this issue Oct 29, 2016 · 1 comment
Closed

Metricbeat diskio metricset doesn't work on Windows XP/2003 #2885

andrewkroh opened this issue Oct 29, 2016 · 1 comment
Labels
bug Metricbeat Metricbeat :Windows

Comments

@andrewkroh
Copy link
Member

The diskio metricset always produces an error on Windows XP. Running the same query on command line works. This is the query gopsutil runs:

PS > Get-WmiObject -query "SELECT * FROM Win32_PerfFormattedData_PerfDisk_LogicalDisk "

For confirmed bugs, please report:

  • Version: master (compiled for GOOS=386)
  • Operating System: Windows XP (2003 should be the same)
  • Steps to Reproduce: Enable diskio metricset.
{
  "@timestamp": "2016-10-29T14:11:00.135Z",
  "beat": {
    "hostname": "newxp_2007",
    "name": "newxp_2007",
    "version": "6.0.0-alpha1"
  },
  "error": "disk io counters: Unknown name.",
  "metricset": {
    "module": "system",
    "name": "diskio",
    "rtt": 721036
  },
  "system": {
    "diskio": {}
  },
  "type": "metricsets"
}
@andrewkroh
Copy link
Member Author

If we pull in an updated version of github.com/StackExchange/wmi the problem goes away. This PR fixed the problem. StackExchange/wmi#14

@andrewkroh andrewkroh mentioned this issue Oct 29, 2016
Merged
andrewkroh added a commit to andrewkroh/beats that referenced this issue Oct 31, 2016
@andrewkroh
Update github.com/StackExchange/wmi to e54cbda6595d7293a7a468ccf9525f…
2797565 
…6bc8887f99

This will fix issues with WMI queries on Windows XP and 2003. Fixes elastic#2885
andrewkroh added a commit to andrewkroh/beats that referenced this issue Oct 31, 2016
@andrewkroh
Metricbeat system module updates for Windows
eb88c2c 
- Added system core metricset for Windows. Per core metrics were implemented
  in elastic/gosigar.
- Added logging of process/system details on Windows to aid in debugging (user,
  arch, cores, sid, privs).
- Fixes elastic#2860 (PPID is zero on Windows).
- Fixes elastic#1704 (Server 2003 - PID’s not recognized). The command line arguments
  for the process will not be reported on XP and 2003.
- Fixes elastic#1897 (OpenProcess access denied on Windows). Added code to enable the
  SeDebugPrivilege when it is available.
- Fixes elastic#2885 (diskio metricset fails on XP and 2003).
- Enabled fsstats by default in Metricbeat config.
ruflin pushed a commit that referenced this issue Oct 31, 2016
@andrewkroh @ruflin
Update github.com/StackExchange/wmi to e54cbda6595d7293a7a468ccf9525f…
020e8a1 
…6bc8887f99

This will fix issues with WMI queries on Windows XP and 2003. Fixes #2885
ruflin pushed a commit that referenced this issue Oct 31, 2016
@andrewkroh @ruflin
Metricbeat system module updates for Windows
b44bdd6 
- Added system core metricset for Windows. Per core metrics were implemented
  in elastic/gosigar.
- Added logging of process/system details on Windows to aid in debugging (user,
  arch, cores, sid, privs).
- Fixes #2860 (PPID is zero on Windows).
- Fixes #1704 (Server 2003 - PID’s not recognized). The command line arguments
  for the process will not be reported on XP and 2003.
- Fixes #1897 (OpenProcess access denied on Windows). Added code to enable the
  SeDebugPrivilege when it is available.
- Fixes #2885 (diskio metricset fails on XP and 2003).
- Enabled fsstats by default in Metricbeat config.
andrewkroh added a commit to andrewkroh/beats that referenced this issue Nov 1, 2016
@andrewkroh
Metricbeat system module updates for Windows
79e94f6 
- Added system core metricset for Windows. Per core metrics were implemented
  in elastic/gosigar.
- Added logging of process/system details on Windows to aid in debugging (user,
  arch, cores, sid, privs).
- Fixes elastic#2860 (PPID is zero on Windows).
- Fixes elastic#1704 (Server 2003 - PID’s not recognized). The command line arguments
  for the process will not be reported on XP and 2003.
- Fixes elastic#1897 (OpenProcess access denied on Windows). Added code to enable the
  SeDebugPrivilege when it is available.
- Fixes elastic#2885 (diskio metricset fails on XP and 2003).
- Enabled fsstats by default in Metricbeat config.

(cherry picked from commit eb88c2c)
andrewkroh added a commit to andrewkroh/beats that referenced this issue Nov 1, 2016
@andrewkroh
Update github.com/StackExchange/wmi to e54cbda6595d7293a7a468ccf9525f…
48cd620 
…6bc8887f99

This will fix issues with WMI queries on Windows XP and 2003. Fixes elastic#2885

(cherry picked from commit 2797565)
@andrewkroh andrewkroh mentioned this issue Nov 1, 2016
Merged
ruflin pushed a commit that referenced this issue Nov 3, 2016
@andrewkroh @ruflin
Metricbeat system module updates for Windows
55f3855 
- Added system core metricset for Windows. Per core metrics were implemented
  in elastic/gosigar.
- Added logging of process/system details on Windows to aid in debugging (user,
  arch, cores, sid, privs).
- Fixes #2860 (PPID is zero on Windows).
- Fixes #1704 (Server 2003 - PID’s not recognized). The command line arguments
  for the process will not be reported on XP and 2003.
- Fixes #1897 (OpenProcess access denied on Windows). Added code to enable the
  SeDebugPrivilege when it is available.
- Fixes #2885 (diskio metricset fails on XP and 2003).
- Enabled fsstats by default in Metricbeat config.

(cherry picked from commit eb88c2c)
ruflin pushed a commit that referenced this issue Nov 3, 2016
@andrewkroh @ruflin
Update github.com/StackExchange/wmi to e54cbda6595d7293a7a468ccf9525f…
75e948b 
…6bc8887f99

This will fix issues with WMI queries on Windows XP and 2003. Fixes #2885

(cherry picked from commit 2797565)
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@andrewkroh @ruflin
Metricbeat system module updates for Windows
a8600a2 
- Added system core metricset for Windows. Per core metrics were implemented
  in elastic/gosigar.
- Added logging of process/system details on Windows to aid in debugging (user,
  arch, cores, sid, privs).
- Fixes elastic#2860 (PPID is zero on Windows).
- Fixes elastic#1704 (Server 2003 - PID’s not recognized). The command line arguments
  for the process will not be reported on XP and 2003.
- Fixes elastic#1897 (OpenProcess access denied on Windows). Added code to enable the
  SeDebugPrivilege when it is available.
- Fixes elastic#2885 (diskio metricset fails on XP and 2003).
- Enabled fsstats by default in Metricbeat config.

(cherry picked from commit eb88c2c)
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@andrewkroh @ruflin
Update github.com/StackExchange/wmi to e54cbda6595d7293a7a468ccf9525f…
1254f97 
…6bc8887f99

This will fix issues with WMI queries on Windows XP and 2003. Fixes elastic#2885

(cherry picked from commit 2797565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Metricbeat Metricbeat :Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewkroh