Add disable performance counters functionality for testing

elastic · Apr 19, 2019 · 82acba3 · 82acba3
1 parent 1119a28
commit 82acba3
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 3 deletions.
diff --git a/metricbeat/module/system/diskio/diskstat_windows_helper.go b/metricbeat/module/system/diskio/diskstat_windows_helper.go
@@ -30,8 +30,9 @@ import (
 )
 
 const (
-	errorSuccess         syscall.Errno = 0
-	ioctlDiskPerformance               = 0x70020
+	errorSuccess            syscall.Errno = 0
+	ioctlDiskPerformance                  = 0x70020
+	ioctlDiskPerformanceOff               = 0x70060
 )
 
 var (
@@ -144,6 +145,40 @@ func enablePerformanceCounters() error {
 	return nil
 }
 
+// disablePerformanceCounters will disable performance counters using the IOCTL_DISK_PERFORMANCE_OFF IOCTL control code
+func disablePerformanceCounters(path string) error {
+	utfPath, err := syscall.UTF16PtrFromString(path)
+	if err != nil {
+		return err
+	}
+	hFile, err := syscall.CreateFile(utfPath,
+		syscall.GENERIC_READ|syscall.GENERIC_WRITE,
+		syscall.FILE_SHARE_READ|syscall.FILE_SHARE_WRITE,
+		nil,
+		syscall.OPEN_EXISTING,
+		syscall.FILE_FLAG_BACKUP_SEMANTICS,
+		0)
+
+	if err != nil {
+		return err
+	}
+	defer syscall.CloseHandle(hFile)
+	var diskPerformanceSize uint32
+	err = syscall.DeviceIoControl(hFile,
+		ioctlDiskPerformanceOff,
+		nil,
+		0,
+		nil,
+		0,
+		&diskPerformanceSize,
+		nil)
+	if err != nil {
+		return err
+	}
+	return nil
+
+}
+
 // getLogicalDriveStrings calls the syscall GetLogicalDriveStrings in order to get the list of logical drives
 func getLogicalDriveStrings() ([]logicalDrive, error) {
 	lpBuffer := make([]byte, 254)

diff --git a/metricbeat/module/system/diskio/diskstat_windows_test.go b/metricbeat/module/system/diskio/diskstat_windows_test.go
@@ -59,7 +59,8 @@ func TestCDriveFilterOnWindowsTestEnv(t *testing.T) {
 	assert.True(t, writeCount > 0)
 	assert.True(t, writeBytes > 0)
 	assert.True(t, writeTime > 0)
-
+	err := disablePerformanceCounters(`\\.\C:`)
+	assert.NoError(t, err)
 }
 
 func TestAllDrivesOnWindowsTestEnv(t *testing.T) {
@@ -72,4 +73,10 @@ func TestAllDrivesOnWindowsTestEnv(t *testing.T) {
 	data, errs := mbtest.ReportingFetchV2(f)
 	assert.Empty(t, errs)
 	assert.True(t, len(data) >= 1)
+	drives, err := getLogicalDriveStrings()
+	assert.NoError(t, err)
+	for _, drive := range drives {
+		err := disablePerformanceCounters(drive.UNCPath)
+		assert.NoError(t, err)
+	}
 }