Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
efd6 committed Jun 23, 2022
1 parent 24963e7 commit 72b5324
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions x-pack/winlogbeat/magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ func Update() { mg.Deps(winlogbeat.Update.All) }
func GoUnitTest(ctx context.Context) error {
mg.SerialCtxDeps(ctx, goTestDeps...)
args := devtools.DefaultGoTestUnitArgs()
// The module unit tests depend on a running docker container to provide
// the ES instance to run the processor pipeline. In the absence of a
// test supervisor or a single test executable to ensure that only a
// single container is running, or additional logic to ensure no network
// collisions, we ensure that only one test package is running at a time.
args.ExtraFlags = append(args.ExtraFlags, "-p", "1")
return devtools.GoTest(ctx, args)
}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/winlogbeat/module/testing.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func testIngestPipeline(t *testing.T, pipeline, pattern string, p *params) {
t.Fatal(err)
}
if *wintest.KeepRunning {
fmt.Fprintln(os.Stdout, "docker-compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
fmt.Fprintln(os.Stdout, "Use this to manually cleanup containers: docker-compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
}
t.Cleanup(func() {
stop := !*wintest.KeepRunning
Expand Down

0 comments on commit 72b5324

Please sign in to comment.