This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Set trial license only when INSTALL_XPACK = Yes and >= 6.3.0 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the trial license in elasticsearch.yml only when INSTALL_XPACK=1 and the version is greater than or equal to 6.3.0. Fixes a bug where trial license was applied when BASIC_SECURITY=1 and the version is greater than or equal to 6.3.0. Fixes #303
This commit checks the license applied to the deployment, if external load balancer or application gateway is deployed.
russcam
changed the title
codebrain
approved these changes
Aug 26, 2019
russcam
added a commit
that referenced
this pull request
Aug 27, 2019
This commit sets the trial license in elasticsearch.yml only when INSTALL_XPACK=1 and the version is greater than or equal to 6.3.0. Fixes a bug where trial license was applied when BASIC_SECURITY=1 and the version is greater than or equal to 6.3.0. Other changes: - check the license applied to the deployment using the Elasticsearch APIs, if external load balancer or application gateway is deployed. - emit total, passed and failed tests on command line for test runs - use the same timestamp in integration test resource groups - deploy an NSG for the backend pool when using a Standard SKU external load balancer Fixes #303 (cherry picked from commit 8903dcc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby a trial license was being applied when
xpackPlugins = Nobut the version of Elasticsearch is one whereby security can be configured with a basic license.In addition to the fix, this PR includes improvements to tests and logging performed:
Fixes #303