This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion supports TLS This commit updates when SSL/TLS certificates can be installed. When xPackPlugins is 'Yes' or Version is >= 6.8.0 and < 7.0.0, or >= 7.1.0 and certificates have been supplied, then configure TLS.
This commit updates when TLS on HTTP layer is configured: 1. esHttpCertBlob or esHttpCaCertBlob supplied and 2. xPackPlugins is 'Yes' or esVersion is 7.1.0+ or starts with 6 and 6.8.0+
This commit adds an integration test for basic license with TLS when the version is >= 7.1.0. This test configures TLS on the HTTP and Transport layers and asserts both Kibana and Logstash can communicate with the cluster.
This commit updates the deployment scripts to configure Security when a basic license is configured and the stack version allows.
Need to run npm run links -- --branch master before merging |
codebrain
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # docs/azure-arm-template.asciidoc
Mpdreamz
reviewed
Jun 10, 2019
@@ -267,6 +268,11 @@ done | |||
# Parameter state changes | |||
######################### | |||
|
|||
# supports security features with a basic license | |||
if [[ $(dpkg --compare-versions "$ES_VERSION" "ge" "7.1.0"; echo $?) -eq 0 || ($(dpkg --compare-versions "$ES_VERSION" "ge" "6.8.0"; echo $?) -eq 0 && $(dpkg --compare-versions "$ES_VERSION" "lt" "7.0.0"; echo $?) -eq 0) ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took me a double read :D
# Configure SSL/TLS for HTTP layer | ||
if [[ -n "${HTTP_CERT}" || -n "$HTTP_CACERT" && ${INSTALL_XPACK} -ne 0 ]]; then | ||
if [[ -n "${HTTP_CERT}" || -n "$HTTP_CACERT" && ${INSTALL_CERTS} -ne 0 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better check, regardless of version 👍
russcam
added a commit
that referenced
this pull request
Jun 11, 2019
This commit adds support for Elastic Stack 7.1.1 and 6.8.0. It includes a change to configure basic security when xPackPlugins is 'Yes' or Version is >= 6.8.0 and < 7.0.0, or >= 7.1.0 and configures TLS when certificates have been supplied, Add an integration test for basic license with TLS when the version is >= 7.1.0. This test configures TLS on the HTTP and Transport layers and asserts both Kibana and Logstash can communicate with the cluster. Closes #279
russcam
added a commit
that referenced
this pull request
Jun 11, 2019
This commit adds support for Elastic Stack 7.1.1 and 6.8.0. It includes a change to configure basic security when xPackPlugins is 'Yes' or Version is >= 6.8.0 and < 7.0.0, or >= 7.1.0 and configures TLS when certificates have been supplied, Add an integration test for basic license with TLS when the version is >= 7.1.0. This test configures TLS on the HTTP and Transport layers and asserts both Kibana and Logstash can communicate with the cluster. Closes #279
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Elastic Stack 7.1.1 and 6.8.0.
The biggest change in adding support for these new versions is related to Elastic Security features TLS and role-based access control (RBAC) now supported in the free basic license level. The deployment scripts for each product have been updated to reflect this change.