This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Enable accelerated networking #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables accelerated networking by default for VM SKUs that support it, for both Elasticsearch nodes and the Kibana VM. Exposes the option to override accelerated networking if necessary. This is exposed in the case that new VMs are introduced that support accelerated networking, or existing VMs are updated to enable accelerated networking, giving users the ability to control accelerated networking behaviour. Closes #224
Ubuntu version is the same for both 5.x and 6.x
|
Need to run before merging |
Mpdreamz
approved these changes
Oct 4, 2018
| @@ -12,6 +12,87 @@ | |||
| "numberOfDataNodes" : 50, | |||
| "numberOfClientNodes" : 20, | |||
| "diskSizes" : ["Small", "Medium", "Large", "XLarge", "XXLarge"], | |||
| "vmAcceleratedNetworking": [ | |||
There was a problem hiding this comment.
It's sad we need to maintain these compat lists rather than ARM exposing this in a apply or noop fashion.
There was a problem hiding this comment.
Agreed 😢 ours can't be only the template that does this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables accelerated networking by default for VM SKUs that support it,
for both Elasticsearch nodes and the Kibana VM.
Exposes the option to override accelerated networking if necessary. This is exposed in
the case that new VMs are introduced that support accelerated networking,
or existing VMs are updated to enable accelerated networking, giving users the ability to
control accelerated networking behaviour.
Closes #224