This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Use resource group to get details for azure-repository storage account #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the parameters required to configure azure repository plugin with an existing storage account in another resource group. Instead of passing the storage account key and endpoint suffix, these values can be determined with the storage account name and resource group. key and suffix are removed and replaced with resourceGroup. Note that this now requires that the storage account and resoruce group exist in the same subscription. The implementation could be expanded in future to accept a subscriptionId, if necessary. Closes #215
|
Run before merging |
Mpdreamz
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use resource group to get details for azure-repository storage account. This was received as feedback from Microsoft on the last template submission.
This commit updates the parameters required to configure azure repository plugin with an
existing storage account in another resource group. Instead of passing the storage account
key and endpoint suffix, these values can be determined with the storage account name and
resource group.
key and suffix are removed and replaced with resourceGroup.
This now requires that the storage account and resoruce group exist in the same
subscription. The implementation could be expanded in future to accept a subscriptionId,
if necessary.
Closes #215