-
Notifications
You must be signed in to change notification settings - Fork 162
Add Logstash to the Marketplace UI and ARM template #223
Conversation
This commit separates out the installation of Java into a separate script, to be reused by both Elasticsearch and Logstash installations
Work in Progress
WIP - untested
Before this PR is merged, a |
@jsvd I've requested a review 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 👍 on the extensive integration tests.
<strong>Check that the size you select is <a href="https://azure.microsoft.com/en-au/regions/services/">available in the region you choose</a></strong>. | ||
</td><td><code>Standard_D1</code></td></tr> | ||
|
||
<tr><td>logstashHeapSize</td><td>integer</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to expose this? Since logstash always deploys on a dedicated VM can we just do the right thing™?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the heap size? If so, I wasn't sure what might be a sensible default, beyond the default in JVM.options (which I think is 1GB?). Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@russcam mind opening an issue for whether we can rid of the parameter?
This PR adds Logstash to the Marketplace UI and ARM template. This is an initial implementation, with possibility to expand in future based on feedback and usage.
Provide the option to deploy a single instance of Logstash, with configurable VM SKU. The default will remain the same and not deploy Logstash.
Allow configurable JVM heap size.
Allow a Base-64 encoded string form of a Logstash conf file be provided, to start Logstash with. Expose variables that can be referenced within the conf file
${ELASTICSEARCH_URL}
: the Elasticsearch endpoint${LOGSTASH_SYSTEM_PASSWORD}
: password of the built-inlogstash_system
user${ELASTICSEARCH_CACERT}
: the path to the CA cert used to secure the ElasticsearchThe value is Base-64 encoded to match how the value is encoded when received from an uploaded file within the UI.
Allow Logstash keystore password to be specified, for use in Logstash versions that have keystore functionality.
Allow additional Logstash plugins to be installed.
Allow additional YAML configuration to append to logstash.yml configured by the template.
For Logstash 6.3.0+ and for Logstash < 6.3.0 where X-Pack plugin is installed, configure X-Pack monitoring. Document whether monitoring is enabled based on if and how TLS is configured for the Elasticsearch HTTP layer.
Closes #157