Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

Create keystore if it doesn't exist #184

Merged
merged 4 commits into from
Apr 23, 2018
Merged

Create keystore if it doesn't exist #184

merged 4 commits into from
Apr 23, 2018

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 23, 2018

This PR fixes a bug where installing repository-azure plugin fails to set azure storage account credentials within the keystore when not installing x-pack, because the keystore does not exist.

Closes #180

@russcam
Copy link
Contributor Author

russcam commented Apr 23, 2018

Links need to be update before merging to master

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -867,7 +874,7 @@ if [[ ! -z "${INSTALL_ADDITIONAL_PLUGINS// }" ]]; then
fi

if [ ${INSTALL_AZURECLOUD_PLUGIN} -ne 0 ]; then
install_azure_cloud_plugin
install_repository_azure_plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@russcam russcam merged commit e37f4ea into master Apr 23, 2018
@russcam russcam deleted the fix/create-keystore branch July 13, 2018 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure-keystore credentials not set
2 participants