-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] OpenTelemetry - add OpenTelemetry protocol support content #4964
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope all my comments are applied properly. GitHub is showing duplicate comments. :-/
[[open-telemetry-elastic-get-started]] | ||
==== Get started | ||
| *Elastic exporter* | The exporter translates the OpenTelemetry trace data collected from your services | ||
and the metrics data collected from your applications and infrastructure to Elastic's protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is a mouthful. I would find a way to break this into a couple of sentences that are easier to parse.
Also, I'm not sure what protocol we mean when we say "Elastic's protocol".
|
||
The APM Server native support of OpenTelemetry protocol integration allows you to send collected telemetry data directly from your applications to APM Server. | ||
Trace data collected from your services and the metrics data collected from your applications and infrastructure are sent using the | ||
OpenTelemetry protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same as the "Elastic's protocol" that you refer to previously? If so, I wound be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is different. This refers to the OpenTelemetry protocol (OTLP).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Elastic's protocol" refers to how Elastic APM Agents send data to a collector, like APM Server. "OTLP" refers to how OpenTelemetry agents send data to a collector, like the OTEL collector. APM Server can now receive native OTLP data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have only reviewed technical details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! A few suggestions.
Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: EamonnTP <Eamonn.Smith@elastic.co> Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co>
Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: EamonnTP <Eamonn.Smith@elastic.co> Co-authored-by: Cyrille Le Clerc <cyrille.leclerc@elastic.co>
Summary
This PR updates the current OpenTelemetry integration docs with the recent support for OTLP/gRPC on the standard port.
To accommodate the new content, I have restructured the content to include both the Elastic OpenTelemetry integrations: Elastic exporter on the OpenTelemetry collector and APM Server native support of OpenTelemetry protocol. I have also included updated architecture diagrams for both integrations.
Docs preview
https://apm-server_4964.docs-preview.app.elstc.co/guide/en/apm/get-started/master/open-telemetry-elastic.html
Related issue
Closes #4678