beater/config: fix TLS config tests #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to ensure ssl.{certificate,key} are specified
if ssl is enabled. Beats now ensures certificate and key
are both specified for server TLS configuration; this PR
is a prerequisite to updating our libbeat dependency.
|
jenkins run the tests please |
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #3962 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 137 137
Lines 6257 6257
=======================================
Hits 4986 4986
Misses 1271 1271 |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jul 13, 2020
Update tests to ensure ssl.{certificate,key} are specified
if ssl is enabled. Beats now ensures certificate and key
are both specified for server TLS configuration; this PR
is a prerequisite to updating our libbeat dependency.
axw
added a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update tests to ensure ssl.{certificate,key} are specified
if ssl is enabled. Beats now ensures certificate and key
are both specified for server TLS configuration; this PR
is a prerequisite to updating our libbeat dependency.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make testRelated issues
elastic/beats#19584