github-action: support PR author implicitely #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
May 6, 2024
| @@ -8,24 +8,22 @@ inputs: | |||
| repository: | |||
| description: 'The GitHub repository' | |||
| default: ${{ github.repository }} | |||
| user: | |||
| description: 'The GitHub PR onwer' | |||
| default: ${{ github.event.pull_request.head.repo.owner.login }} | |||
There was a problem hiding this comment.
This context didn't work well for PRs in the upstream
reakaleek
previously approved these changes
May 6, 2024
reakaleek
reviewed
May 6, 2024
Co-authored-by: Jan Calanog <nejcalanog@gmail.com>
kuisathaverat
approved these changes
May 6, 2024
reakaleek
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove support for user.
Fetch author of the PR
Why is it important?
Forked PRs are okey but PRs from the upstream won't work since the author is elastic. Let's use the PR author instead and fetch it using the existing GitHub action.