This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
[apm-ui] File names don't match the previous expected ones #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Feb 21, 2020
| @@ -17,17 +17,17 @@ interface DocType { | |||
| const docTypes: DocType[] = [ | |||
| { | |||
| interfaceName: 'SpanRaw', | |||
| interfacePath: '../apm-ui-interfaces/raw/SpanRaw', | |||
| interfacePath: '../apm-ui-interfaces/raw/span_raw', | |||
There was a problem hiding this comment.
Master branch name file:
7.6 branch name file:
I've no clue if it's possible to support different interfaces at the same time.
Otherwise, the changes in master are breaking changes in this particular implementation. No clue how to move forward
kuisathaverat
approved these changes
Feb 21, 2020
mdelapenya
approved these changes
Feb 21, 2020
cachedout
approved these changes
Feb 24, 2020
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Feb 24, 2020
v1v
added a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the new files. It does not allow backward compatiblity
Why is it important?
Fix the APM-ITS for the UI
Related issues
Leftover from #770