Support events without domain attr #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeTheSalad
commented
Apr 25, 2024
| event.Event.Category = "device" | ||
| if eventName == "crash" { | ||
| action := strings.TrimPrefix(eventName, "device.") |
There was a problem hiding this comment.
The goal of trimming the device. prefix here is so that any existing verifications down the road for specific action names, such as crash for example, keep working as usual. However, I'm open to alternative approaches in case this change could cause issues that I might not be aware of.
bryce-b
reviewed
Jun 5, 2024
bryce-b
approved these changes
Jun 5, 2024
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
event.domainattribute was removed from the semconv spec here and, the values that would otherwise be set into theevent.domainattribute, must now be set as a namespace to theevent.namevalue.This PR is to make apm-data aware of this change while keeping backward compatibility, so that both implementations are properly identified as events.