Remote config options for 7.7 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
approved these changes
Mar 30, 2020
| self.span_frames_min_duration = None | ||
|
|
||
| @property | ||
| def span_frames_min_duration(self): |
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* api_request_size default should be 768kb * Add tests for capture_headers remote config * Fix api_request_size/_time to be dynamic * Fix span_frames_min_duration to be dynamic * Test that transaction_sample_rate supports remote config
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* api_request_size default should be 768kb * Add tests for capture_headers remote config * Fix api_request_size/_time to be dynamic * Fix span_frames_min_duration to be dynamic * Test that transaction_sample_rate supports remote config
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* api_request_size default should be 768kb * Add tests for capture_headers remote config * Fix api_request_size/_time to be dynamic * Fix span_frames_min_duration to be dynamic * Test that transaction_sample_rate supports remote config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests support for the remote config options being added in Kibana for 7.7. (All config options technically support remote config, but we need to test that propagation works properly.)
List:
capture_headerscapture_bodyapi_request_sizeapi_request_timespan_frames_min_durationtransaction_sample_ratetransaction_max_spansI'll be opening a separate PR for
enabled/recordedonce I get to those, since they're not as urgent (and will require more work).Related issues
Refs elastic/apm#213