Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend dependency granularity for nosql databases #1639

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Sep 19, 2022

What does this pull request do?

Implement service target fields for

  • Cassandra
  • MongoDB/pymongo
  • Elasticsearch (will be handled in separate PR)

Related issues

Doesn't quite close #1586

@apmmachine
Copy link
Contributor

apmmachine commented Sep 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-26T08:02:21.988+0000

  • Duration: 29 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 4988
Skipped 3338
Total 8326

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Sep 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.831% (17517/19500) 👍 0.023
Conditionals 77.103% (3199/4149) 👎 -0.041

@beniwohli beniwohli marked this pull request as ready for review September 22, 2022 15:18
@beniwohli beniwohli merged commit 6a8f94c into elastic:main Sep 26, 2022
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 27, 2022
@beniwohli beniwohli deleted the service-target-nosql branch September 28, 2022 06:59
basepi pushed a commit that referenced this pull request Oct 3, 2022
* fix errors in pymongo tests introduced in #1639

* fix cursor refresh destination tracking
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 11, 2022
…ith-k8s-skaffold

* upstream/main:
  bump python versions and use docker slim versions (elastic#1661)
  use github actions for pre-commit checks (elastic#1658)
  Use typing.TypeVar on decorators' type hints (elastic#1655)
  Use minimum of 5 seconds for interval between central config calls (elastic#1652)
  fix errors in pymongo tests introduced in elastic#1639 (elastic#1648)
  only use content-type and content-encoding headers for POSTing events (elastic#1651)
  fix starlette 0.21 tests (elastic#1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants