Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid IPv4 vs IPv6 ambiguity in default 'serverUrl' by using '127.0.0.1' rather than 'localhost' #3049

Merged
merged 4 commits into from
Dec 8, 2022
Merged

fix: avoid IPv4 vs IPv6 ambiguity in default 'serverUrl' by using '127.0.0.1' rather than 'localhost' #3049

merged 4 commits into from
Dec 8, 2022

Commits on Nov 28, 2022

  1. fix: avoid IPv4 vs IPv6 ambiguity in default 'serverUrl' by using '12… 

    …7.0.0.1' rather than 'localhost'

Starting in node v17 the defaults for DNS resolution order was
changed (nodejs/node#39987) such that
`dns.lookup()` no longer sorted IPv4 addresses first. This impacts
usage of the *default* APM Server URL (the `serverUrl` config var),
'http://localhost:8200', when using node >=17 because the APM server
only binds to the IPv4 address by default
(elastic/apm-server#1405).

Fixes: #3045
    @trentm
    trentm committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5a33615 View commit details
    Browse the repository at this point in the history

  2. expect a default 'serverUrl' in agent config now

    @trentm
    trentm committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8247b3a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. update docs; drop debugging print

    @trentm
    trentm committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    33f4fac View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. bump to elastic-apm-http-client@11.0.4 to get elastic/apm-nodejs-http… 

    …-client#190 (though it isn't strictly needed)
    @trentm
    trentm committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c49804e View commit details
    Browse the repository at this point in the history