Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exit spans across all module instrumentations #2645

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Apr 15, 2022

Implements: #2601

Marks database/datastore style spans and outgoing service request spans as exit spans, adjusts SQS tests to reflect that lack of an HTTP span.

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 15, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Apr 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-15T16:24:12.828+0000

  • Duration: 21 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 244597
Skipped 0
Total 244597

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm astorm requested a review from trentm April 15, 2022 18:09
@astorm astorm marked this pull request as ready for review April 15, 2022 18:09
@astorm astorm merged commit da8ef47 into main Apr 19, 2022
@astorm astorm deleted the astorm/exit-span-o-rama branch April 19, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants