Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable hapi tests in Node.js 10 #455

Closed
watson opened this issue Jul 19, 2018 · 1 comment
Closed

Re-enable hapi tests in Node.js 10 #455

watson opened this issue Jul 19, 2018 · 1 comment

Comments

@watson
Copy link
Contributor

watson commented Jul 19, 2018 •
edited by alvarolobato
Loading

We disabled hapi tests in Node 10 because of a bug in Node core/V8. This should have been fixed since Node 10.4.0, but if we reenable the tests, they start failing. As far as I can see this is for different reasons and might just be because hapi behaves slightly different on Node 10 (and our test suite expects it to behave like normal). So we'll have to go over each failing test and see if it's expected behavior and if so just fix the tests.
@watson
Copy link
Contributor Author

watson commented Jul 19, 2018

For details see #449

Qard pushed a commit to Qard/apm-agent-nodejs that referenced this issue Aug 4, 2018
test(hapi): reenable for 10.8+
14d4a40 
Fixes elastic#455
@Qard Qard mentioned this issue Aug 4, 2018
Merged
Qard pushed a commit to Qard/apm-agent-nodejs that referenced this issue Aug 7, 2018
test(hapi): reenable for 10.8+
9e9787b 
Fixes elastic#455
@Qard Qard closed this as completed in #493 Aug 7, 2018
Qard added a commit that referenced this issue Aug 7, 2018
@Qard
test(hapi): reenable for 10.8+ (#493)
8fa0921 
Fixes #455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@watson @alvarolobato