-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High cardinality for HTTP span names #2067
Comments
* fix: span name should comply with spec #2067
A fix for the high cardinality in http span names has been merged. We're unable to reproduce the following behavior
That is -- we do appear to be setting these values. Moving ticket to blocked until we can get a repro/description of the context behavior. |
Re: the missing Per this morning's planning meeting, the edge instance that didn't have these fields appears to be running APM Server 8.0 -- you can tell by both the It looks like the APM Server code that handles this transformation didn't land until 7.10. In other words -- the agent is fulfilling its contract by setting these fields and modern versions of APM Server are correctly transforming them. The reason these fields are missing from the edge instance is an old version of APM server is shipping this data. Moving this back into blocked for the time being. |
Per research done, this appears to have been an edge ingest issue. Current versions of the agent are setting these properties. Closing this out as done for now, but will reopen if more evidence comes forward. |
* fix: span name should comply with spec elastic#2067
I've noticed deviations from the HTTP span spec.
The Node.js agent sets the
span.name
to the full URL path, such asGET opbeans:3000/api/products/top
. This leads to thespan.name
having a high cardinality. That's an issue as we'd like to create metrics that have the span name as a dimension. However, it's unclear whether we'd roll up metrics for http spans in the first iteration, or only for db spans.Also, the properties
context.http.url
andcontext.http.status_code
are not populated.The text was updated successfully, but these errors were encountered: