Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and specific agent classes bootdelegation #376

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Dec 9, 2018

All classes except public API, OpenTracing bridge and some tests were moved and repackaged under an internal agent root - co.elastic.apm.agent. Bootdelegation was enabled for this root package.

closes #362

@codecov-io
Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #376   +/-   ##
=========================================
  Coverage     72.39%   72.39%           
  Complexity     1195     1195           
=========================================
  Files           131      131           
  Lines          4484     4484           
  Branches        459      459           
=========================================
  Hits           3246     3246           
  Misses         1029     1029           
  Partials        209      209
Impacted Files Coverage Δ Complexity Δ
...m/agent/plugin/api/TransactionInstrumentation.java 52.38% <ø> (ø) 3 <0> (?)
...agent/configuration/validation/RegexValidator.java 100% <ø> (ø) 6 <0> (?)
.../co/elastic/apm/agent/impl/payload/SystemInfo.java 55.55% <ø> (ø) 6 <0> (?)
...ic/apm/agent/servlet/ServletTransactionHelper.java 73.01% <ø> (ø) 38 <0> (?)
...va/co/elastic/apm/agent/impl/transaction/Http.java 73.68% <ø> (ø) 10 <0> (?)
...n/java/co/elastic/apm/agent/util/VersionUtils.java 60% <ø> (ø) 4 <0> (?)
...co/elastic/apm/agent/servlet/ServletApiAdvice.java 9.67% <ø> (ø) 2 <0> (?)
...elastic/apm/agent/impl/payload/ProcessFactory.java 79.59% <ø> (ø) 0 <0> (?)
...java/co/elastic/apm/agent/impl/transaction/Db.java 59.45% <ø> (ø) 12 <0> (?)
...ent/servlet/helper/StartAsyncAdviceHelperImpl.java 0% <ø> (ø) 0 <0> (?)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702d130...37b8cd0. Read the comment docs.

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

difficult to review but LGTM from skimming over it

@eyalkoren eyalkoren force-pushed the refactor-and-specific-agent-classes-bootdelegation branch from b2835c7 to 368cc91 Compare December 10, 2018 10:30
@eyalkoren eyalkoren force-pushed the refactor-and-specific-agent-classes-bootdelegation branch from 368cc91 to 37b8cd0 Compare December 10, 2018 10:41
@eyalkoren eyalkoren merged commit 5de1437 into elastic:master Dec 10, 2018
@eyalkoren eyalkoren deleted the refactor-and-specific-agent-classes-bootdelegation branch January 9, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public API does not work on WildFly
4 participants