module/apmsql: fix error capture #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing the (initial nil) error value to finishSpan by mistake. Pass a pointer to the result error var instead, to capture the final value. Fixes elastic#159
axw
force-pushed
the
apmsql-defer-captureerror
branch
from
f14ee33 to
11857d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 70 70
Lines 3992 3992
=======================================
Hits 3081 3081
Misses 695 695
Partials 216 216
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing the (initial nil) error value
to finishSpan by mistake. Pass a pointer to the
result error var instead, to capture the final
value.
Fixes #159