Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmgocql: add tracing observer #148

Merged
merged 1 commit into from
Jul 20, 2018
Merged

module/apmgocql: add tracing observer #148

merged 1 commit into from
Jul 20, 2018

Conversation

axw
Copy link
Member

@axw axw commented Jul 19, 2018

Add an observer for gocql single and batch query executions, which creates spans if the context contains a transaction.

Closes #34

@axw axw force-pushed the apmgocsql branch 3 times, most recently from 64a8096 to 2c00d99 Compare July 19, 2018 09:19
@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #148 into master will increase coverage by 0.55%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   77.43%   77.99%   +0.55%     
==========================================
  Files          65       67       +2     
  Lines        3856     3976     +120     
==========================================
+ Hits         2986     3101     +115     
- Misses        663      666       +3     
- Partials      207      209       +2
Impacted Files Coverage Δ
internal/sqlscanner/scanner.go 88.88% <ø> (ø)
internal/sqlscanner/token.go 60% <ø> (ø)
module/apmsql/signature.go 84.7% <ø> (ø) ⬆️
module/apmgocql/observer.go 95.65% <95.65%> (ø)
module/apmgocql/signature.go 98.64% <98.64%> (ø)
tracer.go 84.34% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be556d5...f4baee9. Read the comment docs.

Add an observer for gocql single and
batch query executions, which creates
spans if the context contains a
transaction.
@axw axw merged commit a955a76 into elastic:master Jul 20, 2018
@axw axw deleted the apmgocsql branch July 20, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants