Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction.Context methods for setting user IDs #144

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

axw
Copy link
Member

@axw axw commented Jul 16, 2018

Add methods to Transaction.Context for setting the user ID/username/email. Remove the ability to set a numeric user ID.

Closes #143

Add methods to Transaction.Context for setting the
user ID/username/email. Remove the ability to set
a numeric user ID.
@codecov-io
Copy link

Codecov Report

Merging #144 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   77.01%   77.43%   +0.42%     
==========================================
  Files          65       65              
  Lines        3863     3856       -7     
==========================================
+ Hits         2975     2986      +11     
+ Misses        679      663      -16     
+ Partials      209      207       -2
Impacted Files Coverage Δ
model/marshal.go 68% <ø> (+2.59%) ⬆️
context.go 83.33% <100%> (+3.57%) ⬆️
model/marshal_fastjson.go 73.21% <100%> (ø) ⬆️
tracer.go 84.92% <0%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f8a5a...902b803. Read the comment docs.

@axw axw merged commit 9538b20 into elastic:master Jul 16, 2018
@axw axw deleted the context-user branch July 16, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants