This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Introduce es_java_home variable to allow setting JAVA_HOME #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Hi @timdev, |
|
hi @jmlrt - I did so right after submitting the PR. Let me know if you need me to do so again. |
|
jenkins test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a variable called
es_java_home, which defaults to an empty string. If set to a non-empty string, that string is used to set the JAVA_HOME environment variable in the default config file (via thetemplates/elasticsearch.j2template).If
es_java_homeis not changed from its default, the file generated from the template is unchanged. That is to say, this change should be entirely backwards-compatible.