Removing package version hold when es_version_hold: false

[LukeRoz]

Fix for #499

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[ghost]

Hi @LukeRoz, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

[jmlrt]

jenkins test this please

[jmlrt]

@LukeRoz test are failing on CentOS with the following error:

07:53:52        TASK [elasticsearch : RedHat - check elasticsearch version lock] ***************
07:53:53         [WARNING]: Consider using the yum module rather than running 'yum'.  If you
07:53:53        need to use command because yum is insufficient you can add 'warn: false' to
07:53:53        this command task or set 'command_warnings=False' in ansible.cfg to get rid of
07:53:53        this message.
07:53:53        
07:53:53        fatal: [localhost]: FAILED! => {"changed": true, "cmd": "yum versionlock list | grep -c elasticsearch", "delta": "0:00:00.698033", "end": "2019-09-04 07:53:53.894887", "msg": "non-zero return code", "rc": 1, "start": "2019-09-04 07:53:53.196854", "stderr": "", "stderr_lines": [], "stdout": "0", "stdout_lines": ["0"]}

https://devops-ci.elastic.co/job/elastic+ansible-elasticsearch+pull-request/41/OS=centos-7,TEST_TYPE=oss,VERSION=7.x,label=linux/console

[jmlrt]

jenkins test this please

[jmlrt]

unhold elasticsearch package when switching to a different package type task on debian and RedHat - unlock elasticsearch version task on redhat are failing at idempotency tests:

• https://devops-ci.elastic.co/job/elastic+ansible-elasticsearch+pull-request/48/OS=ubuntu-1404,TEST_TYPE=oss,VERSION=7.x,label=linux/console
• https://devops-ci.elastic.co/job/elastic+ansible-elasticsearch+pull-request/48/OS=centos-7,TEST_TYPE=oss,VERSION=7.x,label=linux/console

These tasks shouldn't change anything during the second ansible deployment.

[jmlrt]

jenkins test this please

[jmlrt]

jenkins test this please

[jmlrt]

why do you need a | cat here?

[LukeRoz]

Hm... OK, | cat is unnecessary now. Deleting.

[jmlrt]

jenkins test this please

[jmlrt]

jenkins test this please

[jmlrt]

LGTM 👍