This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
fix ''dict object has no attribute dict_keys" issue with python3 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python2, the dict.keys(), dict.values(), and dict.items() methods returns a list. Jinja2 returns that to Ansible via a string representation that Ansible can turn back into a list. In Python3, those methods return a dictionary view object. resource: https://docs.ansible.com/ansible/2.4/playbooks_python_version.html#dictionary-views
Crazybus
reviewed
Jun 7, 2019
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| - name: set fact manage_file_users | |||
| set_fact: manage_file_users=es_users is defined and es_users.file is defined and es_users.file.keys() | length > 0 | |||
There was a problem hiding this comment.
Why are some of these now .keys() | list while others are just list with the .keys() also removed? I can't figure out why some still need .keys() and some don't.
There was a problem hiding this comment.
There were a few more were it was removed. Which is why I thought it was on purpose. At least 2 more in this PR where it was deleted.
There was a problem hiding this comment.
Are you sure? I don't see no more | list without .keys()
|
Thanks! Quick turn-around! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python2, the dict.keys(), dict.values(), and dict.items() methods returns a list. Jinja2 returns that to Ansible via a string representation that Ansible can turn back into a list. In Python3, those methods return a dictionary view object.
resource: https://docs.ansible.com/ansible/2.4/playbooks_python_version.html#dictionary-views
Fix #570