Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update elasticsearch-parameters.yml #513

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

kakoni
Copy link
Contributor

@kakoni kakoni commented Nov 19, 2018

Fixing data_dirs name typo

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Crazybus
Crazybus previously approved these changes Nov 26, 2018
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix!

If you look at the comment above you will see that you still need to sign the CLA before I can merge this one in.

@kakoni
Copy link
Contributor Author

kakoni commented Nov 26, 2018

CLA signed. (karri.niemela@beans.fi)

@Crazybus
Copy link
Contributor

@kakoni It looks like you made the commits with a different email address. If you add the email you are using for these commits into your GitHub profile it will properly detect you as being verified.

You can see the email address here

@kakoni kakoni changed the title Update elasticsearch-parameters.yml Update elasticsearch-parameters.yml and elasticsearch.yml.j2 Dec 22, 2018
@kakoni
Copy link
Contributor Author

kakoni commented Dec 22, 2018

@Crazybus Wow, sorry, way too much lag on my side. Anyway fixed my profile.
I also added another fix for this PR, fixes #517

templates/elasticsearch.yml.j2 Outdated Show resolved Hide resolved
@kakoni kakoni changed the title Update elasticsearch-parameters.yml and elasticsearch.yml.j2 Update elasticsearch-parameters.yml Dec 27, 2018
@kakoni
Copy link
Contributor Author

kakoni commented Dec 27, 2018

@Crazybus Fixed this so that it only includes the type fix.

Crazybus
Crazybus previously approved these changes Dec 28, 2018
@Crazybus
Copy link
Contributor

@kakoni the cla checker is still not happy I'm afraid :(

Looking at the commits in https://patch-diff.githubusercontent.com/raw/elastic/ansible-elasticsearch/pull/513.patch it seems that you are committing with a different email address than the one you signed the cla with. If you add this email address (from the patch link) into your profile then it will work. Otherwise there is no way to match your commit messages up.

Fixing data_dirs name typo
@kakoni
Copy link
Contributor Author

kakoni commented Dec 28, 2018

@Crazybus So;) One more try, changed commiter email for 69c49fc so that its the same as with cla. (I do have two emails in profile also, but it seems that its not working?)

@Crazybus
Copy link
Contributor

Crazybus commented Jan 7, 2019

@Crazybus So;) One more try, changed commiter email for 69c49fc so that its the same as with cla. (I do have two emails in profile also, but it seems that its not working?)

@kakoni The problem is that you still have 3 commits in this PR all with different email addresses. You can see them listed in this URL: https://patch-diff.githubusercontent.com/raw/elastic/ansible-elasticsearch/pull/513.patch

@kakoni
Copy link
Contributor Author

kakoni commented Jan 8, 2019

Extra comments removed from PR, patch looks decent.

@Crazybus
Copy link
Contributor

Crazybus commented Jan 8, 2019

@kakoni woo! What a journey that was for such a small change. Thanks for finding and fixing the typo!

@Crazybus Crazybus merged commit b37723a into elastic:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants