-
Notifications
You must be signed in to change notification settings - Fork 857
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the typo fix!
If you look at the comment above you will see that you still need to sign the CLA before I can merge this one in.
CLA signed. (karri.niemela@beans.fi) |
@kakoni It looks like you made the commits with a different email address. If you add the email you are using for these commits into your GitHub profile it will properly detect you as being verified. You can see the email address here |
@Crazybus Fixed this so that it only includes the type fix. |
@kakoni the cla checker is still not happy I'm afraid :( Looking at the commits in https://patch-diff.githubusercontent.com/raw/elastic/ansible-elasticsearch/pull/513.patch it seems that you are committing with a different email address than the one you signed the cla with. If you add this email address (from the patch link) into your profile then it will work. Otherwise there is no way to match your commit messages up. |
Fixing data_dirs name typo
@kakoni The problem is that you still have 3 commits in this PR all with different email addresses. You can see them listed in this URL: https://patch-diff.githubusercontent.com/raw/elastic/ansible-elasticsearch/pull/513.patch |
Extra comments removed from PR, patch looks decent. |
@kakoni woo! What a journey that was for such a small change. Thanks for finding and fixing the typo! |
Fixing data_dirs name typo