Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked room window - no longer spams "look" #19

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Reworked room window - no longer spams "look" #19

merged 3 commits into from
Jul 1, 2024

Conversation

strnglp
Copy link
Contributor

@strnglp strnglp commented Jun 22, 2024

The previous version spammed "look" which congested log files.

mrhoribu
mrhoribu reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@mrhoribu mrhoribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the one comment I added. Thanks for submitting this and optimizing the code to be better.

ui/text.rb Show resolved Hide resolved
@mrhoribu mrhoribu merged commit fab3907 into elanthia-online:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrhoribu mrhoribu mrhoribu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strnglp @mrhoribu