Better validate ACL configuration #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACL configuration may not be a boolean or just any string. It must be a valid XACML. While we can't easily parse the XACML and check its correctness, we can at least check if the ACL seems to be XML. The background for this is that with Opencast 14, `acl = "false"` was a valid configuration. This silently changed with Opencast 15(?) and caused Studio to upload ACL files with the contents `false", causing problems in later processing steps of Opencast. This patch makes this at least easier to spot.
LukasKalbertodt
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Hu, that's weird. I never intended there to be a breaking change and it must have been the result of some other change? Or a dependency update? I'm interested in what caused this, but unless someone needs to know, I won't invest the time in tracking this down.
The patch looks good!
|
It's been 3 weeks since I've looked at this, but iirc, it was your change introducing more typing to the code that chenged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACL configuration may not be a boolean or just any string. It must be a valid XACML. While we can't easily parse the XACML and check its correctness, we can at least check if the ACL seems to be XML.
The background for this is that with Opencast 14,
acl = "false"was a valid configuration. This silently changed with Opencast 15(?) and caused Studio to upload ACL files with the contents `false", causing problems in later processing steps of Opencast. This patch makes this at least easier to spot.