Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README out of date #84

Open
betchart opened this issue Mar 19, 2012 · 4 comments
Open

README out of date #84

betchart opened this issue Mar 19, 2012 · 4 comments

Comments

@betchart
Copy link
Collaborator

In particular, the quickstart suggests running analyses/example.py, which doesn't exist!

@gerbaudo
Copy link
Collaborator

I tried to update the readme, mostly to understand the github 'pull request'. I think I must have done something wrong, because I committed directly to the master, rather than going through a 'pull request'. Here is what I've done:
cd supy/
git status
git checkout -b fix-readme
enw readme.txt
git add readme.txt
git commit -m 'fix readme'
git status
git fetch origin master
git checkout master
git pull origin master
git merge fix-readme
git push origin
I thought that git would not allow me to push directly to the master...did I miss one step?
Sorry for the n00b mistake...

@gerbaudo
Copy link
Collaborator

Maybe I should have read this page more carefully...
https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Fork-and-Pull-Request-workflow
I'll be more careful next time, sorry.

@betchart
Copy link
Collaborator Author

Hi Davide,

The usual pattern with a pull request is as follows:

git status (master, clean, up to date with origin)
git checkout -b some-project
git add some.txt
git add file.txt
git commit -m "some file, etc"
git push origin some-project

then go to github and select the some-project branch, and hit the pull
request button.

Burt

On Mon, Mar 19, 2012 at 8:57 PM, Davide Gerbaudo
reply@reply.github.com
wrote:

I tried to update the readme, mostly to understand the github 'pull request'. I think I must have done something wrong, because I committed directly to the master, rather than going through a 'pull request'. Here is what I've done:
 cd supy/
 git status
 git checkout -b fix-readme
 enw readme.txt
 git add readme.txt
 git commit -m 'fix readme'
 git status
 git fetch  origin master
 git checkout master
 git pull origin master
 git merge fix-readme
 git push origin
I thought that git would not allow me to push directly to the master...did I miss one step?
Sorry for the n00b mistake...


Reply to this email directly or view it on GitHub:
#84 (comment)

@betchart
Copy link
Collaborator Author

Its no big deal, and a good learning experience.

On Mon, Mar 19, 2012 at 9:01 PM, Davide Gerbaudo
reply@reply.github.com
wrote:

Maybe I should have read this page more carefully...
https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Fork-and-Pull-Request-workflow
I'll be more careful next time, sorry.


Reply to this email directly or view it on GitHub:
#84 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants