Basic palette selector #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhang
reviewed
Nov 9, 2023
| @@ -68,6 +66,16 @@ | |||
| export let termEl: HTMLDivElement = null as any; // suppress "missing prop" warning | |||
| let term: Terminal | null = null; | |||
|
|
|||
| import { settings } from "$lib/settings"; | |||
| import type { ITheme } from "xterm"; | |||
There was a problem hiding this comment.
We should move imports to the top of the file and sort them
| <div class="text-red-500">Coming soon</div> | ||
| <div> | ||
| <select | ||
| class="w-52 px-3 py-1.5 rounded-md bg-zinc-700 outline-none focus:ring-2 focus:ring-indigo-500" |
There was a problem hiding this comment.
From your screenshot, the arrow at the right side of the dropdown (when closed) is a bit too close to the right edge of the element
| let theme: ITheme = themes.defaultDark; | ||
|
|
||
| $: if ($settings.theme && term) { | ||
| theme = themes[$settings.theme]; |
There was a problem hiding this comment.
Can we fall back to defaultDark if this is undefined?
|
Hi @Cveinnt, any update on this? |
|
Hi @Cveinnt — I haven't gotten a response in 3 months, hope all is well. I'll use this as the base of implementing the feature now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a basic palette selector in the form of a dropdown menu, and added some basic themes for the users to choose from. The preset themes are converted from https://github.com/alacritty/alacritty-theme/.
Dropdown menu preview:
Example theme preview: