Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hybrid Nodes] Remove strict requirement of providing a VGW or TGW during cluster creation #8168

Conversation

TiberiuGC
Copy link
Collaborator

Description

At the moment, the field remoteNetworkConfig.vpcGatewayID is required when relying on eksctl to create a VPC for you. Removing this requirement comes with the advantage that users no longer need to provide a pre-existing VPC if their hybrid nodes connectivity method does not involve a TGW or VGW. Instead, eksctl will create the VPC for them, with recommended SG rules in place (for hybrid nodes), but no other additional networking pre-requisites (for hybrid nodes).

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC changed the title [Hybrid Nodes] Remote strict requirement of providing a VGW or TGW during cluster creation [Hybrid Nodes] Remove strict requirement of providing a VGW or TGW during cluster creation Jan 29, 2025
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@TiberiuGC TiberiuGC merged commit 74c2b1f into eksctl-io:main Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants