fix: filter out NaN values

The implementation would panic before in AlgorithmicIndexer
ekroon · Jan 5, 2023 · ac8a8d6 · ac8a8d6
1 parent 799994d
commit ac8a8d6
Showing 1 changed file with 22 additions and 1 deletion.
diff --git a/src/lib.rs b/src/lib.rs
@@ -80,6 +80,9 @@ impl<'a> StringSpark<'a> {
         let mut max: Option<&f64> = self.max.as_ref();
         if min.is_none() || max.is_none() {
             for v in data {
+                if v.is_nan() {
+                    continue;
+                }
                 if let Some(m) = min {
                     if v < m {
                         min = Some(v);
@@ -104,7 +107,9 @@ impl<'a> StringSpark<'a> {
             } else {
                 let indexer = self.build_indexer.build_indexer(*min, *max, self.ticks);
                 data.iter().for_each(|v| {
-                    result.push(self.ticks[indexer.index(*v)]);
+                    if !v.is_nan() {
+                        result.push(self.ticks[indexer.index(*v)]);
+                    }
                 });
             }
         }
@@ -156,6 +161,22 @@ mod tests {
         assert_eq!(spark.spark(&[1.0, 2.0, 3.0]), "abc");
     }
 
+    #[test]
+    fn test_nan() {
+        let spark = StringSpark::default();
+        assert_eq!(spark.spark(&[f64::NAN, 1.0, 2.0, f64::NAN, 3.0]), "▁▅█");
+    }
+
+    #[ignore]
+    #[test]
+    fn test_infinite() {
+        let spark = StringSpark::default();
+        assert_eq!(
+            spark.spark(&[f64::NEG_INFINITY, 0.0, f64::INFINITY,]),
+            "▁▅█"
+        );
+    }
+
     #[test]
     fn test_spark_fn() {
         assert_eq!(spark(&[1.0, 2.0, 3.0]), "▁▅█");