Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide for better Platform support and testing #350

Merged
merged 28 commits into from
Dec 28, 2023
Merged

Provide for better Platform support and testing #350

merged 28 commits into from
Dec 28, 2023

Conversation

ekrich
Copy link
Owner

@ekrich ekrich commented Sep 28, 2023 •
edited
Loading

  • Provide basic abstract classes and Platform support
  • Migrate methods to common
  • Refactor tests for common
  • Migrate methods to JVM Native
  • Allow for JVM Native tests
  • Copy resources except beanconfig to jvm-native
  • Enable embedded resources in Native test application
  • Refactor for JVM Native
  • Migrate the rest of the methods to JVM

We will need a followup to get File and resource support for Scala Native.
This allow java.io.Reader loading for JS and Native and brings the tests up to 318 from 154.
JVM still has 532 tests.

ekrich added 26 commits December 4, 2023 09:46
@ekrich
Add classes to allow migrations of methods to specific platforms
1d265ff
@ekrich
Move some common methods
38a520f
@ekrich
Move platform to config package
916578c
@ekrich
Format
19192b4
@ekrich
Remove ConfigFactoryCommon
7ecf0a9
@ekrich
Shared JVM Native tests work
b110582
@ekrich
Add resources to jvm-native, embedded resources, add back common
e88efed
@ekrich
Rollback test file move
784c2c0
@ekrich
Move parseString to common
1da6730
@ekrich
Works good for all platforms, stub for JvmNative
d6313c8
@ekrich
Add two Reader tests to Native
a5dc426
@ekrich
Make default build 2.13 and rename ConfigDocumentTest to ConfigDocume…
c2a92b3 
…ntFactoryTest
@ekrich
Move ConfigFactoryTests to impl like other tests
1599b94
@ekrich
Move tests from ConfigTest to ConfigFactoryJvmTest and then ConfigTes…
49ae320 
…t to shared
@ekrich
Make test class names singular
eae2319
@ekrich
Checkpoint commit for ConfigOrigin setup
026e579
@ekrich
Update to more shared tests, add URL for Native, from 189 to 228 test…
7d9f09f 
…s for Native
@ekrich
Add env vars to shared in anticipation of using them in Native or JS
94a39eb
@ekrich
Move ConfigSubstitutionTests to shared
75652b0
@ekrich
Json4s almost works
afc02f2
@ekrich
Json4s cleanup
e0f2c52
@ekrich
Got json4s test to work
149f2dd
@ekrich
Make comments generic
e3a7bac
@ekrich
JsonTest is now cross platform
0ac9a11
@ekrich
Small updates, JS setting commented out
7f896e4
@ekrich
Upgrade to new version of json4s to fix JS ClassCastException problem
afe558d
@ekrich ekrich merged commit 7b7bddb into main Dec 28, 2023
4 checks passed
@ekrich ekrich deleted the topic/native branch December 28, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ekrich