bump golang to 1.20.1 to address buildvcs=true failure #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older golang:1.19.3-alpine3.15 as builder is failing, due to the go build error 'error obtaining VCS status: exit status 128'. Bumping the builder image to golang:1.20.1-alpine3.17 fixes the this go build failure.
|
Perhaps this VCS status error is only present on my Mac Desktop Docker setup? In any event, my informal testing of using golang 1.20.1 on my home network setup went fine. My rationale: a version bump to the latest stable seems fairly low risk. |
eko
approved these changes
Mar 1, 2023
|
Thank you @wblew, I agree it’s always better to upgrade :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older golang:1.19.3-alpine3.15 as builder is failing, due to the go build error 'error obtaining VCS status: exit status 128'.
Bumping the builder image to golang:1.20.1-alpine3.17 fixes this golang build failure.