Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with iconv in PHP image and use Alpine binary of ci-helper #93

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

mremi
Copy link
Member

@mremi mremi commented Jan 26, 2018

See docker-library/php#240

Before:

php -d error_reporting=22527 -d display_errors=1 -r 'var_dump(iconv("UTF-8", "UTF-8//IGNORE", "This is the Euro symbol '\'''\''."));'
Notice: iconv(): Wrong charset, conversion from `UTF-8' to `UTF-8//IGNORE' is not allowed in Command line code on line 1

After:

php -d error_reporting=22527 -d display_errors=1 -r 'var_dump(iconv("UTF-8", "UTF-8//IGNORE", "This is the Euro symbol '\'''\''."));'
Command line code:1:
string(30) "This is the Euro symbol '€'."

@mremi mremi changed the title Fix issue with iconv in PHP image WIP: Fix issue with iconv in PHP image Jan 26, 2018
@mremi mremi force-pushed the master branch 2 times, most recently from 7f85372 to f1609f8 Compare January 29, 2018 08:45
@mremi mremi changed the title WIP: Fix issue with iconv in PHP image Fix issue with iconv in PHP image Jan 29, 2018
@mremi mremi requested a review from rande January 29, 2018 09:00
@mremi mremi changed the title Fix issue with iconv in PHP image WIP: Fix issue with iconv in PHP image Jan 29, 2018
@mremi mremi force-pushed the master branch 3 times, most recently from 2b16034 to 10f82c1 Compare January 29, 2018 11:17
@mremi mremi changed the title WIP: Fix issue with iconv in PHP image Fix issue with iconv in PHP image Jan 29, 2018
@mremi mremi changed the title Fix issue with iconv in PHP image Fix issue with iconv in PHP image and use Alpine binary of ci-helper Jan 29, 2018
@mremi mremi merged commit 137b876 into ekino:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant