Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation carom balls #169

Merged
merged 8 commits into from
Jan 1, 2025
Merged

Conversation

erdo100
Copy link
Contributor

@erdo100 erdo100 commented Dec 31, 2024

Added:

  • Carom billiard ball visualizations

Changed:

  • standard size of balls
  • standard size of table
  • height of cushion nose

@erdo100 erdo100 requested a review from ekiefl as a code owner December 31, 2024 13:00
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.22%. Comparing base (dd6f2ef) to head (ab2668f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files         127      127           
  Lines        8551     8551           
=======================================
  Hits         3782     3782           
  Misses       4769     4769           
Flag Coverage Δ
service 44.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekiefl
Copy link
Owner

ekiefl commented Jan 1, 2025

Congratulations @erdo100 on becoming a contributor of pooltool. Thanks for your contribution, and I hope you consider contributing more in the future. Merging now.

@ekiefl ekiefl merged commit 67ff6bf into ekiefl:main Jan 1, 2025
9 checks passed
@erdo100 erdo100 deleted the visualisation_carom_balls branch January 6, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants