Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda support #203

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Conda support #203

merged 2 commits into from
Feb 20, 2018

Conversation

0Xellos
Copy link
Contributor

@0Xellos 0Xellos commented Feb 17, 2018

The present options for autodetecting virtual environments (-p switch) work for virtualenv and venv, but not conda, which sets sys.base_prefix and changes sys.prefix to the same value as sys.base_prefix.

My fix also checks if the environment variable CONDA_PREFIX is set and uses base_prefix as the environment directory in that case.

added support for conda virtual environments
@ekalinin
Copy link
Owner

Hey @0Xellos!

Thanks for patch. Could you fix too long line?

https://travis-ci.org/ekalinin/nodeenv/jobs/342802175#L530

@0Xellos
Copy link
Contributor Author

0Xellos commented Feb 19, 2018

Fixed.

@ekalinin ekalinin merged commit 42765a0 into ekalinin:master Feb 20, 2018
@ekalinin
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants