Fix Windows support for installing node and npm from prebuilt #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit disables support for building from source *under Windows* altogether as we cannot really rely on a fixed environment (like gcc, make, etc) being present on Windows. I may add that support in the future * Under Windows, we need to always download npm seperately as it doesn't come bundled with the node.exe that we use. * Activation scripts are copied verbatim from ekalinin/nodeenv@windows-support * Using the node system version is not supported under Windows as we have no reliable way of knowing where it is installed
|
Great patch! |
This was referenced Dec 7, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables support for building from source under Windows
altogether as we cannot really rely on a fixed environment (like gcc,
make, etc) being present on Windows. I may add that support in the
future
Under Windows, we need to always download npm seperately as it doesn't
come bundled with the node.exe that we use.
Activation scripts are copied verbatim from
ekalinin/nodeenv@windows-support
Using the node system version is not supported under Windows as we have
no reliable way of knowing where it is installed