Test clean task in CI
#896
Conversation
|
The problem on Windows is the |
Co-authored-by: Werner Dietl <wdietl@gmail.com>
Thanks! |
| @@ -17,3 +17,6 @@ source "$SCRIPTDIR"/clone-related.sh | |||
| # Moved example-tests out of all tests because it fails in | |||
| # the release script because the newest maven artifacts are not published yet. | |||
| ./gradlew :checker:exampleTests -x javadoc -x allJavadoc --console=plain --warning-mode=all | |||
|
|
|||
There was a problem hiding this comment.
Is there any benefit to also test this here? Isn't it enough to test in the junit script?
There was a problem hiding this comment.
I think :checker:examplesTests are tests run makefiles
checker-framework/checker/build.gradle
Line 305 in 304e999
There was a problem hiding this comment.
Can you elaborate a bit what your point is?
We already test running ./gradlew clean in junit above. Do you want to clean at the end of every test? Or why is :checker:examplesTests relevant for whether we call clean here?
There was a problem hiding this comment.
I think Junit test doesn't contain makefile tests such as exampleTests, is that correct? Because exampleTests are the tests for makefiles and ./gradlew clean will also run make clean for makefile tests. I just want to make it works after we actual run makefile tests in CI.
There was a problem hiding this comment.
There are no tests that actually ensure that clean cleaned up everything - so you won't know whether this call to clean actually removed all files that were generated from exampleTests.
So what do you learn from calling clean here?
There was a problem hiding this comment.
okay, I will clean up them. Thanks!
wmdietl
changed the title
clean task in CI
Fixes #413