Unicode support #31

sirex · 2016-01-04T14:34:11Z

Run these tests: tox -e py26,py27,py34, don't have other snakes.

The-Compiler · 2016-01-04T14:40:51Z

You might want to use a backslash-escape (i.e. \uXXXX) instead of a literal to get things working with Python 3.2.

abusalimov · 2016-01-04T15:26:58Z

Thanks for the contribution! Can we avoid the 'six' dependency? I'm pretty sure, there should be the same compat type somewhere in py.builtin.

The-Compiler · 2016-01-04T15:32:42Z

six.text_type is py.builtin.text I think, and probably you can use py.builtin._totext instead of six.u.

sirex · 2016-01-04T16:10:15Z

py.builtin._totext did not worked out of the box: https://bitbucket.org/pytest-dev/py/issues/75/pybuiltin_totext-does-not-work-with-python

But after replacing _totext, removed six dependency.

I think, py should use six too, instead of reinventing the wheel.

The-Compiler · 2016-01-04T16:20:34Z

I bet py existed before six did (but I didn't check) 😉

The long-term plan for pytest is to move away from pylib, though.

abusalimov · 2016-01-04T16:46:54Z

pytest_catchlog.py

+                obj = obj.decode(encoding)
+            else:
+                obj = obj.decode(encoding, errors)
+        return obj


It is only used in the test. Do we need it here?

I added it here to be able to access it from testdir.makepyfile. If there is a batter way how to make _totext visible from testdir.makepyfile, I can fix it.

abusalimov · 2016-01-04T17:30:53Z

@The-Compiler maybe we could permit usage of six for testing, WDYT? Apparently, _totext is broken, and we need u(...) in tests...

The-Compiler · 2016-01-04T17:34:51Z

I'd personally prefer using u'...' strings and dropping Python 3.2 support, like some other testing tools (like coverage.py or hypothesis) already did.

abusalimov · 2016-01-04T22:33:13Z

@The-Compiler I agree, but let's wait at least until pytest-core drops 3.2 support first. After all, Python 2.6 support (which is about to be dropped in pytest 2.9) has been added just recently (#17). It would be unreasonable to abandon 3.2, but retain 2.6 compatibility.

Another option is to use u'...' literals and skip the test for Python 3.2. @sirex what do you think?

sirex · 2016-01-04T23:19:19Z

To leave 3.2 support, while pytest-core still supports it seems reasonable to me.

But for this one unicode test I can add skip condition for 3.2, just to remove this _totext workaround.

abusalimov · 2016-01-04T23:25:38Z

just to remove this _totext workaround.

This is exactly what I meant 👍

sirex · 2016-01-04T23:48:26Z

Can't skip py32, because it fails to load whole file containing u''. So instead just added small u() lambdas that does just smallest minimum needed for tests to support all pythons.

abusalimov · 2016-01-04T23:55:39Z

LGTM! Could you squash the whole branch into a single commit, please? 🏁

See eisensheng#30

The-Compiler · 2016-01-05T05:17:10Z

LGTM as well!

Unicode support

7: Pin pytest-catchlog to latest version 1.2.2 r=aragilar a=pyup-bot This PR pins [pytest-catchlog](https://pypi.org/project/pytest-catchlog) to the latest release **1.2.2**. <details> <summary>Changelog</summary> ### 1.2.2 ``` ------------- Released on 2016-01-24 UTC. - [Bugfix] `30`_ `31`_ - Fix ``unicode`` vs ``str`` compatibility issues between Python2 and Python3. (Thanks goes to `sirex`_ for reporting the issue and providing a fix!) .. _30: eisensheng/pytest-catchlog#30 .. _31: eisensheng/pytest-catchlog#31 .. _sirex: https://github.com/sirex ``` ### 1.2.1 ``` ------------- Released on 2015-12-07. - [Bugfix] 18 - Allow ``caplog.records()`` to be modified. Thanks to Eldar Abusalimov for the PR and Marco Nenciarini for reporting the issue. - [Bugfix] 15 17 - Restore Python 2.6 compatibility. (Thanks to Marco Nenciarini!) .. attention:: Deprecation warning: the following objects (i.e. functions, properties) are slated for removal in the next major release. - ``caplog.at_level`` and ``caplog.set_level`` should be used instead of ``caplog.atLevel`` and ``caplog.setLevel``. The methods ``caplog.atLevel`` and ``caplog.setLevel`` are still available but deprecated and not supported since they don't follow the PEP8 convention for method names. - ``caplog.text``, ``caplog.records`` and ``caplog.record_tuples`` were turned into properties. They still can be used as regular methods for backward compatibility, but that syntax is considered deprecated and scheduled for removal in the next major release. ``` ### 1.2 ``` ----------- Released on 2015-11-08. - [Feature] 6 - Configure logging message and date format through ini file. - [Feature] 7 - Also catch logs from setup and teardown stages. - [Feature] 7 - Replace deprecated ``__multicall__`` use to support future Py.test releases. - [Feature] 11 - reintroduce ``setLevel`` and ``atLevel`` to retain backward compatibility with pytest-capturelog. Also the members ``text``, ``records`` and ``record_tuples`` of the ``caplog`` fixture can be used as properties now. Special thanks for this release goes to Eldar Abusalimov. He provided all of the changed features. ``` ### 1.1 ``` ----------- Released on 2015-06-07. - 2 - Explicitly state Python3 support and add configuration for running tests with tox on multiple Python versions. (Thanks to Jeremy Bowman!) - Add an option to silence logs completely on the terminal. ``` ### 1.0 ``` ----------- Released on 2014-12-08. - Add ``record_tuples`` for comparing recorded log entries against expected log entries with their logger name, severity and formatted message. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest-catchlog - Changelog: https://pyup.io/changelogs/pytest-catchlog/ - Repo: https://github.com/eisensheng/pytest-catchlog </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

18: Pin pytest-catchlog to latest version 1.2.2 r=aragilar a=pyup-bot This PR pins [pytest-catchlog](https://pypi.org/project/pytest-catchlog) to the latest release **1.2.2**. <details> <summary>Changelog</summary> ### 1.2.2 ``` ------------- Released on 2016-01-24 UTC. - [Bugfix] `30`_ `31`_ - Fix ``unicode`` vs ``str`` compatibility issues between Python2 and Python3. (Thanks goes to `sirex`_ for reporting the issue and providing a fix!) .. _30: eisensheng/pytest-catchlog#30 .. _31: eisensheng/pytest-catchlog#31 .. _sirex: https://github.com/sirex ``` ### 1.2.1 ``` ------------- Released on 2015-12-07. - [Bugfix] 18 - Allow ``caplog.records()`` to be modified. Thanks to Eldar Abusalimov for the PR and Marco Nenciarini for reporting the issue. - [Bugfix] 15 17 - Restore Python 2.6 compatibility. (Thanks to Marco Nenciarini!) .. attention:: Deprecation warning: the following objects (i.e. functions, properties) are slated for removal in the next major release. - ``caplog.at_level`` and ``caplog.set_level`` should be used instead of ``caplog.atLevel`` and ``caplog.setLevel``. The methods ``caplog.atLevel`` and ``caplog.setLevel`` are still available but deprecated and not supported since they don't follow the PEP8 convention for method names. - ``caplog.text``, ``caplog.records`` and ``caplog.record_tuples`` were turned into properties. They still can be used as regular methods for backward compatibility, but that syntax is considered deprecated and scheduled for removal in the next major release. ``` ### 1.2 ``` ----------- Released on 2015-11-08. - [Feature] 6 - Configure logging message and date format through ini file. - [Feature] 7 - Also catch logs from setup and teardown stages. - [Feature] 7 - Replace deprecated ``__multicall__`` use to support future Py.test releases. - [Feature] 11 - reintroduce ``setLevel`` and ``atLevel`` to retain backward compatibility with pytest-capturelog. Also the members ``text``, ``records`` and ``record_tuples`` of the ``caplog`` fixture can be used as properties now. Special thanks for this release goes to Eldar Abusalimov. He provided all of the changed features. ``` ### 1.1 ``` ----------- Released on 2015-06-07. - 2 - Explicitly state Python3 support and add configuration for running tests with tox on multiple Python versions. (Thanks to Jeremy Bowman!) - Add an option to silence logs completely on the terminal. ``` ### 1.0 ``` ----------- Released on 2014-12-08. - Add ``record_tuples`` for comparing recorded log entries against expected log entries with their logger name, severity and formatted message. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest-catchlog - Changelog: https://pyup.io/changelogs/pytest-catchlog/ - Repo: https://github.com/eisensheng/pytest-catchlog </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

abusalimov reviewed Jan 4, 2016
View reviewed changes

Unicode support

3ed66c2

See eisensheng#30

sirex force-pushed the develop branch from 5095912 to 3ed66c2 Compare January 5, 2016 00:10

abusalimov added a commit that referenced this pull request Jan 5, 2016

Merge pull request #31 from sirex/develop

faba94c

Unicode support

abusalimov merged commit faba94c into eisensheng:develop Jan 5, 2016

eisensheng added a commit that referenced this pull request Jan 18, 2016

Reflect changes from #31 in CHANGES.rst

58703a8

The-Compiler mentioned this pull request Mar 26, 2016

Performance test harness #40

Merged

pyup-bot mentioned this pull request Sep 25, 2016

Initial Update aio-libs/aiokafka#50

Merged

This was referenced Mar 31, 2017

Pin pytest-catchlog to latest version 1.2.2 inmanta/inmanta-core#306

Closed

Pin pytest-catchlog to latest version 1.2.2 inmanta/inmanta-core#331

Closed

Pin pytest-catchlog to latest version 1.2.2 inmanta/inmanta-core#356

Closed

pyup-bot mentioned this pull request Jun 1, 2017

Pin pytest-catchlog to latest version 1.2.2 aryamccarthy/gapjunctions#24

Merged

pyup-bot mentioned this pull request Aug 16, 2017

Pin pytest-catchlog to latest version 1.2.2 springermac/pyinstaller#35

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unicode support #31

Unicode support #31

sirex commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

sirex commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov Jan 4, 2016

sirex Jan 4, 2016

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov commented Jan 4, 2016

sirex commented Jan 4, 2016

abusalimov commented Jan 4, 2016

sirex commented Jan 4, 2016

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 5, 2016

Unicode support #31

Unicode support #31

Conversation

sirex commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

sirex commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov Jan 4, 2016

Choose a reason for hiding this comment

sirex Jan 4, 2016

Choose a reason for hiding this comment

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 4, 2016

abusalimov commented Jan 4, 2016

sirex commented Jan 4, 2016

abusalimov commented Jan 4, 2016

sirex commented Jan 4, 2016

abusalimov commented Jan 4, 2016

The-Compiler commented Jan 5, 2016