Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs detected during parsing NXapm_compositionspace_results int… #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkuehbach
Copy link
Collaborator

Fixed bugs detected during parsing NXapm_compositionspace_results into the NOMAD feature branch on developing a NOMAD app for atom probe, further context via pynxtools-apm apm_app and apm_app_tools branch, part of issue #36 on www.github.com/FAIRmat-NFDI/pynxtools-apm.git

…o the NOMAD feature branch on developing a NOMAD app for atom probe, further context via pynxtools-apm apm_app and apm_app_tools branch, part of issue #36 on www.github.com/FAIRmat-NFDI/pynxtools-apm.git
@mkuehbach mkuehbach requested a review from srmnitc February 7, 2025 14:23
@mkuehbach
Copy link
Collaborator Author

@srmnitc @thohamm @Alaukiksaxena anybody, feel free to merge in after the DFG symposium.
This PR implements a bug fix to allow drag-and-drop parsing NXapm_compositionspace_results and making searchable content of NeXus files straight in NOMAD.
On a sidenote (also in prep for the paper @thohamm, @hickel), results from paraprobe-toolbox are have been made substantially more searchable in a NOMAD feature branch focusing on atom probe. We are currently working on making this available in the main development branch of NOMAD as well.
FYI @sanbrock

@mkuehbach
Copy link
Collaborator Author

@Alaukiksaxena or @srmnitc CompositionSpace version should be bumped from 0.1.4 to 0.1.5 to make a new conda release for these changes to take effect once this PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants