Fix#657 add proxy environment variables for npm postinstalls #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds http_proxy and https_proxy for npm runs, useful for npm postinstalls that use pure node <postinstall-script>.js to get the proxy without workarounds.
…proxy Those variables are needed for postinstall steps using node scripts
…or_npm_postinstalls
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #683
Summary
Found that for postinstall script, such openlayers 4 has, in a proxy network, this plugin is not passing right the proxy to node.js running the script.
Tests and Documentation
This fixes issue #657.
I tested and it seems to work with openlayers 4.6.4
Thanks @Cavva79