Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for children props #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

XcrossD
Copy link

@XcrossD XcrossD commented Aug 17, 2022

Component usage

const Work = () => {
  const childElements = workData.map((elem, index) => {
    return (
      <div className="masonry__brick" data-aos="fade-up" key={index}>
        <div className="item-folio">
          <div className="item-folio__thumb">
              <a href={elem.url} className="thumb-link" title={elem.title}>
                <DynamicImage
                  // fileName={elem.image}
                  fileName="portfolio/lady-shutterbug.jpg"
                  alt={elem.title}
                />
              </a>
          </div>
          <div className="item-folio__text">
            <h3 className="item-folio__title">
              {elem.title}
            </h3>
            <p className="item-folio__cat">
              {elem.category}
            </p>
          </div>
          <a href={elem.url} className="item-folio__project-link" title="Project link">
              <i className="icon-link"></i>
          </a>
          <div className="item-folio__caption">
            <p>{elem.description}</p>
          </div>
        </div>
      </div>
    );
  });
  
  return (
    <section id="works" className="s-works target-section">
      <div className="row section-header has-bottom-sep narrow target-section" data-aos="fade-up">
        <div className="col-full">
          <h3 className="subhead">Portfolio</h3>
          <h1 className="display-1">
            Check out my recent works.
          </h1>
        </div>
      </div>
      <div className="row masonry-wrap">
        <Masonry
          className={'masonry'} // default ''
          // elementType={'ul'} // default 'div'
          // options={masonryOptions} // default {}
          // disableImagesLoaded={false} // default false
          // updateOnEachImageLoad={false} // default false and works only if disableImagesLoaded is false
          // imagesLoadedOptions={imagesLoadedOptions} // default {}
        >
          {childElements}
        </Masonry>
      </div>
    </section>
  );
};

export default Work;

I encountered the following typescript error

Type '{ children: Element[]; className: string; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<MasonryPropTypes, any, any>> & Readonly<...>'.
  Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<MasonryPropTypes, any, any>> & Readonly<...>'.ts(2322)

children is indeed not typed in https://github.com/eiriklv/react-masonry-component/blob/master/typings.d.ts#L19 so I created this pull request.

@l-hankins
Copy link

@eiriklv Simple adjustment to support React 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants