feat(sgartifactregistry): determine if access token is expired on npm auth #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alethenorio
force-pushed
the
check-token-expiry
branch
from
8c30f32 to
7627022
Compare
filiptammergard
approved these changes
Nov 22, 2023
… auth When using `gcloud auth print-access-token`, gcloud will print the token regardless on whether the token is expired or not. We use gcloud to figure out if the token is expired for a better user experience (instead of the user getting back a 403 which can be confusing)
alethenorio
force-pushed
the
check-token-expiry
branch
from
7627022 to
47c5f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
gcloud auth print-access-token, gcloud will print the tokenregardless on whether the token is expired or not.
We use gcloud to figure out if the token is expired for a better user
experience (instead of the user getting back a 403 which can be
confusing)