Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Route Import #190

Merged
merged 2 commits into from
Aug 2, 2024
Merged

feat: Add support for Route Import #190

merged 2 commits into from
Aug 2, 2024

Conversation

parmus
Copy link
Contributor

@parmus parmus commented Aug 2, 2024

  • feat: Add support for Route Import
    This implementation of RouteImport() only supports the same subset of parameters as Routes()
  • feat: Add support for "length" span attribute

@parmus parmus marked this pull request as ready for review August 2, 2024 12:26
@parmus parmus requested a review from a team as a code owner August 2, 2024 12:26
Copy link
Member

@odsod odsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! See comment about GoDoc formatting before merge

Copy link
Collaborator

@alethenorio alethenorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A small nit

routingv8/routes.go Outdated Show resolved Hide resolved
parmus added 2 commits August 2, 2024 15:48
This implementation of RouteImport() only supports the same subset of parameters as Routes()
@parmus parmus force-pushed the parmus/route_import branch from df99ed1 to 2f03064 Compare August 2, 2024 13:49
@parmus parmus merged commit db9e516 into master Aug 2, 2024
1 check passed
@parmus parmus deleted the parmus/route_import branch August 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants