Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geocodingsearchv7): export ResponseError and add status code to it #157

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

alfredgunnar
Copy link
Member

No description provided.

@alfredgunnar alfredgunnar requested a review from a team as a code owner October 16, 2023 07:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #157 (a192c19) into master (fc4f0cc) will increase coverage by 5.08%.
Report is 75 commits behind head on master.
The diff coverage is 24.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   13.00%   18.09%   +5.08%     
==========================================
  Files          13       19       +6     
  Lines         715     1155     +440     
==========================================
+ Hits           93      209     +116     
- Misses        607      918     +311     
- Partials       15       28      +13     
Files Coverage Δ
routingv7/client.go 0.00% <ø> (ø)
routingv7/types.go 0.00% <ø> (ø)
routingv8/response.go 72.72% <ø> (ø)
routingv7/calculatematrix.go 0.00% <0.00%> (ø)
routingv7/calculateroute.go 0.00% <0.00%> (ø)
routingv8/client.go 60.97% <71.42%> (+10.97%) ⬆️
routingv8/request.go 23.21% <47.61%> (+4.67%) ⬆️
geocodingsearchv7/apikey.go 0.00% <0.00%> (ø)
routingv8/routes.go 67.39% <67.39%> (ø)
geocodingsearchv7/reversegeocoding.go 20.83% <20.83%> (ø)
... and 3 more

Copy link
Contributor

@blaberg blaberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@alfredgunnar alfredgunnar merged commit 54bca65 into master Oct 16, 2023
1 check passed
@alfredgunnar alfredgunnar deleted the geocode-status-code branch October 16, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants