feat: add ShutdownDelay configuration #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an artifical shutdown delay, in order to allow a service to stop receiving requests before it cancells its root context. This is completely opt-in, and the added context cancellation delay will not be added if no duration is configured.
odsod
reviewed
Jan 3, 2024
| go func() { | ||
| <-sigCtx.Done() | ||
| logger.Info("delaying shutdown", zap.Duration("duration", run.config.ShutdownDelay)) | ||
| time.Sleep(run.config.ShutdownDelay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an artifical shutdown delay, in order to allow a service to
stop receiving requests before it cancells its root context. This is
completely opt-in, and the added context cancellation delay will not be
added if no duration is configured.